CVE-2024-36962 net: ks8851: Queue RX packets in IRQ handler instead of disabling BHs

2024-06-0307:50:00

Linux

github.com

linux kernel

net: ks8851

irq handler

softirq

spinlock

mutex

AI Score

Confidence

Low

EPSS

Percentile

15.5%

SSVC

Exploitation

none

Automatable

Technical Impact

partial

JSON

In the Linux kernel, the following vulnerability has been resolved:

net: ks8851: Queue RX packets in IRQ handler instead of disabling BHs

Currently the driver uses local_bh_disable()/local_bh_enable() in its
IRQ handler to avoid triggering net_rx_action() softirq on exit from
netif_rx(). The net_rx_action() could trigger this driver .start_xmit
callback, which is protected by the same lock as the IRQ handler, so
calling the .start_xmit from netif_rx() from the IRQ handler critical
section protected by the lock could lead to an attempt to claim the
already claimed lock, and a hang.

The local_bh_disable()/local_bh_enable() approach works only in case
the IRQ handler is protected by a spinlock, but does not work if the
IRQ handler is protected by mutex, i.e. this works for KS8851 with
Parallel bus interface, but not for KS8851 with SPI bus interface.

Remove the BH manipulation and instead of calling netif_rx() inside
the IRQ handler code protected by the lock, queue all the received
SKBs in the IRQ handler into a queue first, and once the IRQ handler
exits the critical section protected by the lock, dequeue all the
queued SKBs and push them all into netif_rx(). At this point, it is
safe to trigger the net_rx_action() softirq, since the netif_rx()
call is outside of the lock that protects the IRQ handler.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "drivers/net/ethernet/micrel/ks8851_common.c"
    ],
    "versions": [
      {
        "version": "492337a4fbd1",
        "lessThan": "8a3ff43dcbab",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "cba376eb036c",
        "lessThan": "ae87f661f3c1",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "49d5d70538b6",
        "lessThan": "7e2901a2a919",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "be0384bf599c",
        "lessThan": "e0863634bf9f",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "drivers/net/ethernet/micrel/ks8851_common.c"
    ],
    "versions": [
      {
        "version": "6.1.87",
        "lessThan": "6.1.91",
        "status": "affected",
        "versionType": "custom"
      },
      {
        "version": "6.6.28",
        "lessThan": "6.6.31",
        "status": "affected",
        "versionType": "custom"
      },
      {
        "version": "6.8.7",
        "lessThan": "6.8.10",
        "status": "affected",
        "versionType": "custom"
      }
    ]
  }
]