CVE-2024-35879 of: dynamic: Synchronize of_changeset_destroy() with the devlink removals

2024-05-1908:34:36

Linux

github.com

linux

kernel

vulnerability

fix

synchronization

of_changeset_destroy

devlink removals

6.8 Medium

AI Score

Confidence

Low

0.0004 Low

EPSS

Percentile

10.4%

JSON

In the Linux kernel, the following vulnerability has been resolved:

of: dynamic: Synchronize of_changeset_destroy() with the devlink removals

In the following sequence:

of_platform_depopulate()
of_overlay_remove()

During the step 1, devices are destroyed and devlinks are removed.
During the step 2, OF nodes are destroyed but
__of_changeset_entry_destroy() can raise warnings related to missing
of_node_put():
ERROR: memory leak, expected refcount 1 instead of 2 …

Indeed, during the devlink removals performed at step 1, the removal
itself releasing the device (and the attached of_node) is done by a job
queued in a workqueue and so, it is done asynchronously with respect to
function calls.
When the warning is present, of_node_put() will be called but wrongly
too late from the workqueue job.

In order to be sure that any ongoing devlink removals are done before
the of_node destruction, synchronize the of_changeset_destroy() with the
devlink removals.

CNA Affected

[
  {
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "vendor": "Linux",
    "product": "Linux",
    "versions": [
      {
        "status": "affected",
        "version": "d007150b4e15",
        "lessThan": "3127b2ee50c4",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "80dd33cf72d1",
        "lessThan": "3ee242410754",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "80dd33cf72d1",
        "lessThan": "7b6df050c45a",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "80dd33cf72d1",
        "lessThan": "801c8b8ec5bf",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "80dd33cf72d1",
        "lessThan": "ae6d76e4f06c",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "80dd33cf72d1",
        "lessThan": "8917e7385346",
        "versionType": "git"
      }
    ],
    "programFiles": [
      "drivers/of/dynamic.c"
    ],
    "defaultStatus": "unaffected"
  },
  {
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "vendor": "Linux",
    "product": "Linux",
    "versions": [
      {
        "status": "affected",
        "version": "5.13"
      },
      {
        "status": "unaffected",
        "version": "0",
        "lessThan": "5.13",
        "versionType": "custom"
      },
      {
        "status": "unaffected",
        "version": "5.10.215",
        "versionType": "custom",
        "lessThanOrEqual": "5.10.*"
      },
      {
        "status": "unaffected",
        "version": "5.15.154",
        "versionType": "custom",
        "lessThanOrEqual": "5.15.*"
      },
      {
        "status": "unaffected",
        "version": "6.1.85",
        "versionType": "custom",
        "lessThanOrEqual": "6.1.*"
      },
      {
        "status": "unaffected",
        "version": "6.6.26",
        "versionType": "custom",
        "lessThanOrEqual": "6.6.*"
      },
      {
        "status": "unaffected",
        "version": "6.8.5",
        "versionType": "custom",
        "lessThanOrEqual": "6.8.*"
      },
      {
        "status": "unaffected",
        "version": "6.9",
        "versionType": "original_commit_for_fix",
        "lessThanOrEqual": "*"
      }
    ],
    "programFiles": [
      "drivers/of/dynamic.c"
    ],
    "defaultStatus": "affected"
  }
]