Type securityvulns
Reporter Securityvulns
Modified 2006-04-19T00:00:00


commit 37863c8a9b7b0261ec76daad8afffe9ab5314794 Author: Greg Kroah-Hartman <> Date: Mon Apr 17 13:36:51 2006 -0700


commit 512dba41bae0ec8de72269167f23b75a4770097d Author: Hugh Dickins <> Date: Wed Apr 12 14:34:27 2006 -0700

[PATCH] shmat: stop mprotect from giving write permission to a readonly attachment &#40;CVE-2006-1524&#41;

I found that all of 2.4 and 2.6 have been letting mprotect give write
permission to a readonly attachment of shared memory, whether or not IPC
would give the caller that permission.

SUS says &quot;The behaviour of this function [mprotect] is unspecified if the
mapping was not established by a call to mmap&quot;, but I don&#39;t think we can
interpret that as allowing it to subvert IPC permissions.

I haven&#39;t tried 2.2, but the 2.2.26 source looks like it gets it right; and
the patch below reproduces that behaviour - mprotect cannot be used to add
write permission to a shared memory segment attached readonly.

This patch is simple, and I&#39;m sure it&#39;s what we should have done in 2.4.0:
if you want to go on to switch write permission on and off with mprotect,
just don&#39;t attach the segment readonly in the first place.

However, we could have accumulated apps which attach readonly &#40;even though
they would be permitted to attach read/write&#41;, and which subsequently use
mprotect to switch write permission on and off: it&#39;s not unreasonable.

I was going to add a second ipcperms check in do_shmat, to check for
writable when readonly, and if not writable find_vma and clear VM_MAYWRITE.
 But security_ipc_permission might do auditing, and it seems wrong to
report an attempt for write permission when there has been none.  Or we
could flag the vma as SHM, note the shmid or shp in vm_private_data, and
then get mprotect to check.

But the patch below is a lot simpler: I&#39;d rather stick with it, if we can
convince ourselves somehow that it&#39;ll be safe.

Signed-off-by: Hugh Dickins &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 23e0ac040b8052729c32dfec78f751d82515e73e Author: Stephen Hemminger <> Date: Wed Apr 12 14:52:54 2006 -0700

[PATCH] atm: clip causes unregister hang

If Classical IP over ATM module is loaded, its neighbor table gets
populated when permanent neighbor entries are created; but these entries
are not flushed when the device is removed. Since the entry never gets
flushed the unregister of the network device never completes.

This version of the patch also adds locking around the reference to
the atm arp daemon to avoid races with events and daemon state changes.
&#40;Note: barrier&#40;&#41; was never really safe&#41;


Signed-off-by: Stephen Hemminger &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 18b1e8193eef97f3ac854276a7c4bacbb1bdfbd1 Author: Roland McGrath <> Date: Wed Apr 12 16:30:20 2006 -0700

[PATCH] fix non-leader exec under ptrace

This reverts most of commit 30e0fca6c1d7d26f3f2daa4dd2b12c51dadc778a.
It broke the case of non-leader MT exec when ptraced.
I think the bug it was intended to fix was already addressed by commit

Signed-off-by: Roland McGrath &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 49fa79e5689a5c9089a5cdaf396fbdae5f928004 Author: Paul Fulghum <> Date: Wed Apr 12 23:41:59 2006 +0200

[PATCH] USB: remove __init from usb_console_setup

This prevents an Oops if booted with &quot;console=ttyUSB0&quot; but without a
USB-serial dongle, and plugged one in afterwards.

Signed-off-by: Greg Kroah-Hartman &lt;;

commit 6b2467e45179a336f1e5b70d2b2ae1fe89a00133 Author: Pavel Machek <> Date: Fri Mar 31 02:30:06 2006 -0800

[PATCH] Fix suspend with traced tasks

strace /bin/bash misbehaves after resume; this fixes it.

&#40;akpm: it&#39;s scary calling refrigerator&#40;&#41; in state TASK_TRACED, but it seems to
do the right thing&#41;.

Signed-off-by: Pavel Machek &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Linus Torvalds &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit dea8e11ab727c4c7d75d391354eab355cd74e95a Author: Steve French <> Date: Fri Mar 31 21:22:00 2006 +0000

[PATCH] Incorrect signature sent on SMB Read

Fixes Samba bug 3621 and bug 6147

For servers which require SMB/CIFS packet signing, we were sending the
wrong signature &#40;all zeros&#41; on SMB Read request.  The new cifs routine
to do signatures across an iovec was not complete - and SMB Read, unlike
the new SMBWrite2, did not fall back to the older routine &#40;ie use
SendReceive vs. the more efficient SendReceive2 ie used the older
cifs_sign_smb vs. the disabled  cifs_sign_smb2&#41; for calculating signatures.

This finishes up cifs_sign_smb2/cifs_calc_signature2 so that the callers
of SendReceive2 can get SMB/CIFS packet signatures.

Now that cifs_sign_smb2 is supported, we could start using it in
the write path but this smaller fix does not include the change
to use SMBWrite2 when signatures are required &#40;which when enabled
will make more Writes more efficient and alloc less memory&#41;.
Currently Write2 is only used when signatures are not
required at the moment but after more testing we will enable
that as well&#41;.

Thanks to James Slepicka and Sam Flory for initial investigation.

Signed-off-by: Steve French &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 284a7c99c01846ee44040268529c99fc92dcc531 Author: Andrew Morton <> Date: Fri Mar 24 03:18:35 2006 -0800

[PATCH] RLIMIT_CPU: fix handling of a zero limit

At present the kernel doesn&#39;t honour an attempt to set RLIMIT_CPU to zero
seconds.  But the spec says it should, and that&#39;s what 2.4.x does.

Fixing this for real would involve some complexity &#40;such as adding a new
it-has-been-set flag to the task_struct, and testing that everwhere, instead
of overloading the value of it_prof_expires&#41;.

Given that a 2.4 kernel won&#39;t actually send the signal until one second has
expired anyway, let&#39;s just handle this case by treating the caller&#39;s
zero-seconds as one second.

Cc: Martin Schwidefsky &lt;;
Cc: Ulrich Weigand &lt;;
Cc: Cliff Wickman &lt;;
Acked-by: Ingo Molnar &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Linus Torvalds &lt;;

commit bc5bd8ac3c6956c7ce2c838e8e2f01435b8e4e0b Author: Nathan Scott <> Date: Tue Apr 11 15:12:45 2006 +1000

[PATCH] Fix utime&#40;2&#41; in the case that no times parameter was passed in.

SGI-PV: 949858
SGI-Modid: xfs-linux-melb:xfs-kern:25717a

Signed-off-by: Jes Sorensen &lt;;
Signed-off-by: Nathan Scott &lt;;

commit 3e1792fa40be9dd0f530e2b32f439bb97c40bcee Author: Brian Uhrain says <> Date: Mon Apr 10 22:53:16 2006 -0700

[PATCH] alpha: SMP boot fixes

I&#39;ve encountered two problems with 2.6.16 and newer kernels on my API CS20
&#40;dual 833MHz Alpha 21264b processors&#41;.  The first is the kernel OOPSing
because of a NULL pointer dereference while trying to populate SysFS with the
CPU information.  The other is that only one processor was being brought up.
I&#39;ve included a small Alpha-specific patch that fixes both problems.

The first problem was caused by the CPUs never being properly registered using
register_cpu&#40;&#41;, the way it&#39;s done on other architectures.

The second problem has to do with the removal of hwrpb_cpu_present_mask in
arch/alpha/kernel/smp.c.  In setup_smp&#40;&#41; in the 2.6.15 kernel sources,
hwrpb_cpu_present_mask has a bit set for each processor that is probed, and
afterwards cpu_present_mask is set to the cpumask for the boot CPU.  In the
same function of the same file in the 2.6.16 sources, instead of
hwrpb_cpu_present_mask being set, cpu_possible_map is updated for each probed
CPU.  cpu_present_mask is still set to the cpumask of the boot CPU afterwards.
 The problem lies in include/asm-alpha/smp.h, where cpu_possible_map is
#define&#39;d to be cpu_present_mask.

Cleanups from: Ivan Kokshaysky &lt;;

 - cpu_present_mask and cpu_possible_map are essentially the same thing
   on alpha, as it doesn&#39;t support CPU hotplug;
 - allocate &quot;struct cpu&quot; only for present CPUs, like sparc64 does.
   Static array of &quot;struct cpu&quot; is just a waste of memory.

Signed-off-by: Brian Uhrain &lt;;
Cc: Richard Henderson &lt;;
Cc: Ivan Kokshaysky &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit d90fd1f7c1e1003d899df415456f4f7164ff11e1 Author: Mike Miller <> Date: Mon Apr 10 15:38:07 2006 -0700

[PATCH] cciss: bug fix for crash when running hpacucli

Fix a crash when running hpacucli with multiple logical volumes on a cciss
controller.  We were not properly initializing the disk-&gt;queue and causing
a fault.

Thanks to Hasso Tepper for reporting the problem.  Thanks to Steve Cameron
for root causing the problem.  Most of the patch just moves things around.
The fix is a one-liner.

Signed-off-by: Mike Miller &lt;;
Signed-off-by: Stephen Cameron &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 6cbe9c0d5b6c45a0d7ec1365be27b11df4099a9a Author: Randy Dunlap <> Date: Mon Apr 10 20:54:24 2006 +0200

[PATCH] edac_752x needs CONFIG_HOTPLUG

EDAC_752X uses pci_scan_single_device&#40;&#41;, which is only available
if CONFIG_HOTPLUG is enabled, so limit this driver with HOTPLUG.

This patch was already included in Linus&#39; tree.

Adrian Bunk:
Rediffed for 2.6.16.x due to unrelated context changes.

Signed-off-by: Randy Dunlap &lt;;
Signed-off-by: Adrian Bunk &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;
Signed-off-by: David S. Peterson &lt;;

commit 345db2843239353833c28d2e12e32a2429a73b2b Author: Ananiev, Leonid I <> Date: Mon Apr 10 22:54:38 2006 -0700

[PATCH] ext3: Fix missed mutex unlock

Missed unlock_super&#40;&#41;call is added in error condition code path.

Signed-off-by: Leonid Ananiev &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 49e91c3b2131b16ea13e3b44426c5a577e9b4fd8 Author: Stephen Rothwell <> Date: Mon Apr 10 00:17:20 2006 -0700

[PATCH] Fix block device symlink name

As noted further on the this file, some block devices have a / in their
name, so fix the &quot;block:...&quot; symlink name the same as the /sys/block name.

Signed-off-by: Stephen Rothwell &lt;;
Cc: Al Viro &lt;;
Cc: Christoph Hellwig &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 2b53303840e1a8f1c7d007d988e8f497248ca270 Author: Nick Piggin <> Date: Mon Apr 10 16:54:00 2006 -0700

[PATCH] Fix buddy list race that could lead to page lru list corruptions

Rohit found an obscure bug causing buddy list corruption.

page_is_buddy is using a non-atomic test &#40;PagePrivate &amp;&amp; page_count == 0&#41;
to determine whether or not a free page&#39;s buddy is itself free and in the
buddy lists.

Each of the conjuncts may be true at different times due to unrelated
conditions, so the non-atomic page_is_buddy test may find each conjunct to
be true even if they were not both true at the same time &#40;ie. the page was
not on the buddy lists&#41;.

Signed-off-by: Martin Bligh &lt;;
Signed-off-by: Rohit Seth &lt;;
Signed-off-by: Nick Piggin &lt;;
Signed-off-by: KAMEZAWA Hiroyuki &lt;;
Signed-off-by: Linus Torvalds &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit add92b7ade7eb528b7df6153f8bc773f5e2a80f1 Author: Miklos Szeredi <> Date: Tue Apr 11 18:37:57 2006 +0200

[PATCH] fuse: fix oops in fuse_send_readpages&#40;&#41;

During heavy parallel filesystem activity it was possible to Oops the
kernel.  The reason is that read_cache_pages&#40;&#41; could skip pages which
have already been inserted into the cache by another task.
Occasionally this may result in zero pages actually being sent, while
fuse_send_readpages&#40;&#41; relies on at least one page being in the

So check this corner case and just free the request instead of trying
to send it.

Reported and tested by Konstantin Isakov.

Signed-off-by: Miklos Szeredi &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 3a62231e38fe628ec2540fb22276ea1c3af5ddd8 Author: Hirokazu Takata <> Date: Mon Apr 10 22:53:18 2006 -0700

[PATCH] m32r: Fix cpu_possible_map and cpu_present_map initialization for SMP kernel

This patch fixes a boot problem of the m32r SMP kernel 2.6.16-rc1-mm3 or

In this patch, cpu_possible_map is statically initialized, and cpu_present_map
is also copied from cpu_possible_map in smp_prepare_cpus&#40;&#41;, because the m32r
architecture has not supported CPU hotplug yet.

Signed-off-by: Hayato Fujiwara &lt;;
Signed-off-by: Hirokazu Takata &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 1fbbed27cf11386f621b00a033fe557266753c54 Author: Hirokazu Takata <> Date: Mon Apr 10 22:53:20 2006 -0700

[PATCH] m32r: security fix of {get, put}_user macros

Update {get,put}_user macros for m32r kernel.
- Modify get_user to use __get_user_asm macro, instead of __get_user_x macro.
- Remove arch/m32r/lib/{get,put}user.S.
- Some cosmetic updates.

I would like to thank NIIBE Yutaka for his reporting about the m32r kernel&#39;s
security problem in {get,put}_user macros.

There were no address checking for user space access in {get,put}_user macros.

Signed-off-by: Hirokazu Takata &lt;;
Cc: NIIBE Yutaka &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit ea0fcdd684262eed42bb40cceff450ef46a97306 Author: Patrick McHardy <> Date: Thu Apr 6 18:51:38 2006 +0200

[PATCH] NETFILTER: Fix fragmentation issues with bridge netfilter

[NETFILTER]: Fix fragmentation issues with bridge netfilter

The conntrack code doesn&#39;t do re-fragmentation of defragmented packets
anymore but relies on fragmentation in the IP layer. Purely bridged
packets don&#39;t pass through the IP layer, so the bridge netfilter code
needs to take care of fragmentation itself.

Signed-off-by: Patrick McHardy &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 8abb9bed57d5ee0f645eedb7208e8d53b2431b01 Author: Stephen Hemminger <> Date: Wed Apr 5 17:47:15 2006 -0700

[PATCH] sky2: bad memory reference on dual port cards

Sky2 driver will oops referencing bad memory if used on
a dual port card.  The problem is accessing past end of
MIB counter space.

Signed-off-by: Stephen Hemminger &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 905ea1183cb0a6e82ab6de4d4ea0ff0bf807ff27 Author: Randy Dunlap <> Date: Wed Apr 5 12:03:45 2006 -0700

[PATCH] isd200: limit to BLK_DEV_IDE

are set to &#40;y, m&#41; since isd200 calls ide_fix_driveid&#40;&#41; in the

Signed-off-by: Randy Dunlap &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit 27de783e1874115054e079998b3a7f5b06a67b1f Author: Mark Bellon <> Date: Wed Apr 5 01:06:06 2006 -0700

[PATCH] MPBL0010 driver sysfs permissions wide open

The MPBL0010 Telco clock driver &#40;drivers/char/tlclk.c&#41; uses 0222 &#40;anyone
can write&#41; permissions on its writable sysfs entries.  Alter the
permissions to 0220 &#40;owner and group can write&#41;.

The use case for this driver is to configure the fail over behavior of the
clock hardware.  That should be done by the more privileged users.

Signed-off-by: Mark Bellon &lt;;
Acked-by: Gross Mark &lt;;
Signed-off-by: Andrew Morton &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit bb532cb98cd10b4bbb14c0ce253fbaed16a761c4 Author: Laurent MEYER <> Date: Thu Apr 6 08:45:19 2006 +1000

[PATCH] powerpc: fix incorrect SA_ONSTACK behaviour for 64-bit processes

*&#41; When setting a sighandler using sigaction&#40;&#41; call, if the flag
SA_ONSTACK is set and no alternate stack is provided via sigaltstack&#40;&#41;,
the kernel still try to install the alternate stack. This behavior is
the opposite of the one which is documented in Single Unix
Specifications V3.

*&#41; Also when setting an alternate stack using sigaltstack&#40;&#41; with the
flag SS_DISABLE, the kernel try to install the alternate stack on
signal delivery.

These two use cases makes the process crash at signal delivery.

This fixes it.

Signed-off-by: Laurent Meyer &lt;;
Signed-off-by: Paul Mackerras &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;

commit bce29a817a973634535f92aa217152177e82c3bd Author: Stephen Rothwell <> Date: Wed Apr 5 10:41:21 2006 +1000

[PATCH] powerpc: iSeries needs slb_initialize to be called

Since the powerpc 64k pages patch went in, systems that have SLBs
&#40;like Power4 iSeries&#41; needed to have slb_initialize called to set up
some variables for the SLB miss handler.  This was not being called
on the boot processor on iSeries, so on single cpu iSeries machines,
we would get apparent memory curruption as soon as we entered user mode.

This patch fixes that by calling slb_initialize on the boot cpu if the
processor has an SLB.

Signed-off-by: Stephen Rothwell &lt;;
Signed-off-by: Greg Kroah-Hartman &lt;;