Potential reentrancy in the swapTo function of NFTXVaultUpgradeable

Handle shw Vulnerability details Impact The swapTo function in the NFTXVaultUpgradeable contract should use the modifier nonReentrant to prevent reentrancy, which could happen when a user receives an NFT and calls the swapTo function again in the onERC721Received or onERC1155Received functions he...

function swapTo doesn't have a re-entrancy modifier

Handle paulius.eth Vulnerability details Impact function swap has a nonReentrant modifier but function swapTo doesn't. swapTo is a public function so it can be invoked directly. Recommended Mitigation Steps I guess it was meant to be the opposite as swap just invokes swapTo so it could...

Missing allValidNFTs and afterRedeemHook with swapTo?

Handle gpersoon Vulnerability details Impact The function swapTo of NFTXVaultUpgradeable.sol is kind of a combination of mintTo and redeemTo the code looks very similar to a combination of mintTo and redeemTo. Before receiveNFTs I would expect a call to allValidNFTs, like in mintTo. This is to ma...