2 matches found
DAO.sol auth() for ROOT_PERMISSION_ID should not need to depend on hidden IPermissionCondition _auth() from PermissionManager.sol
Lines of code Vulnerability details Summary PermissionManager.sol auth modifier pass along msg.data from all functions, is really out of place. There is little reason to pass along unused data than necessary. It is reasonable to expect ROOTPERMISSIONID and other DAO executive role controlled by...
function applyTargetPermissions() from PermissonManager.sol should use external grant function instead of internal function
Lines of code Vulnerability details Summary applySingleTargetPermissions and applyMultiTargetPermissions use internal function grant, revoke, grantWithCondition in a loop. Each of these internal function have an external function grant, revoke, grantWithCondition do the same thing with extra step...