Admin can break _numberOfValidTokens

Handle cmichel Vulnerability details The ProtocolGovernance.numberOfValidTokens can be decreased by the admin in the ProtocolGovernance.removeFromTokenWhitelist function: function removeFromTokenWhitelistaddress addr external requireisAdminmsg.sender, "ADM"; tokensAllowedaddr = false; if...

tokenWhitelist might break if removeFromTokenWhitelist is called multiple times with the same token

Handle gzeon Vulnerability details Impact In removeFromTokenWhitelist of ProtocolGovernance, numberOfValidTokens is decreased by 1 if addr is in tokenEverAdded. There are no check if the addr is still in the whitelist and therefore numberOfValidTokens can be repeatedly decreased to 0 by calling...

Possible deny of service by human error

Handle 0x1f8b Vulnerability details Impact Possible Deny of service. Proof of Concept The method removeFromTokenWhitelist of the contract ProtocolGovernance doesn't check if the argument addr it's inside the tokensAllowed map before remove it, the problem is if the user call twice this method it'...