Upgraded Q -> H from 41 [1655143123011]

Judge has assessed an item in Issue 41 as High risk. The relevant finding follows: StakedCitadelVester.sol Not implemented IVesting interface. The function vest is named incorrectly . Should be setupVesting called from StakedCitadel.sol. --- The text was updated successfully, but these errors wer...

Function name doesn't match the interface

Lines of code Vulnerability details Impact StakedCitadelVester contract doesn't support the IVesting interface, so the withdrawal of Citadel from the StakedCitadel contract will be impossible because the IVestingvesting.setupVestingmsg.sender, amount, block.timestamp; call will revert because the...

Incorrect interface for StakedCitadelVester causes withdrawals to revert

Lines of code Vulnerability details The IVesting interface contains a setupVesting function: IVesting4 interface IVesting function setupVesting address recipient, uint256 amount, uint256 unlockBegin external; This function is called to send withdrawals to the vesting contract in...