GitLab: Stored XSS on issue comments and other pages which contain notes

Summary This report contains two XSS sanitization bypasses: The SyntaxHighlightFilter creates html from unsanitized data. This can be used to bypass the XSS filter on the server-side. ruby def highlightnodenode ... sourcepos = node.parent.attr'data-sourcepos' ... sourceposattr = sourcepos ?...

GitLab: Stored-XSS on wiki pages

Hello, A Stored-XSS is existing on Wiki pages. It is caused by recent change in show.html.hamlL10 ruby ... "".htmlsafe ... authorurl is defined by committed email in wikipageversion.rb: ruby delegate :message, :sha, :id, :authorname, :authoremail, :authoreddate, to: :commit def authorurl user =...

GitLab: Stored XSS in markdown when redacting references

Summary It's possible to inject arbitrary html into the markdown by abusing the ReferenceRedactorFilter. This is due to the data-original attribute allowing html encoded data to be stored, which is then extracted and used as the link content. If the original data already is html encoded then it...