sp1 has insufficient observation of cumulative sum

During proof generation, the prover must observe all values sent to the verifier to generate valid Fiat-Shamir challenges. Prior to v3.0.0 the cumulative sum of the permutation argument was not observed when sampling zeta, which is a random challenge sampled to force the constraints to be true. I...

PT-2024-40198 · Sp1 · Sp1

Name of the Vulnerable Software and Affected Versions: SP1 versions prior to 3.0.0 Description: The issue arises during proof generation, where the prover must observe all values sent to the verifier to generate valid Fiat-Shamir challenges. In versions prior to 3.0.0, the cumulative sum of the...

Moving average precision is lost

Lines of code Vulnerability details Now the precision is lost in moving average calculations as the difference is calculated separately and added each time, while it typically can be small enough to lose precision in the division involved. For example, 10000 moves of 990 size, numObservations =...