Re-entry in BaseRewardPool.sol

Lines of code Vulnerability details Impact An actor who calls withdraw function for an arbitrary amount in his balance, can re-enter this flow again. As a result, he would get at least double rewards than the designed one. Proof of Concept Say an actor has his contract and has staked funds throug...

Re-entrancy on BaseRewardPool.getReward()

Lines of code Vulnerability details See @audit-info tags: File: BaseRewardPool.sol 280: / 281: @dev Gives a staker their rewards, with the option of claiming extra rewards 282: @param account Account for which to claim 283: @param claimExtras Get the child rewards too? 284: / 285: function...

StrategyPUSDConvex.balanceOfJPEG uses incorrect function signature while calling extraReward.earned, causing the function to unexpectedly revert everytime

Lines of code Vulnerability details Impact As specified in Convex BaseRewardPool.sol and VirtualRewardPool.sol, the function signature of earned is earnedaddress. However, balanceOfJPEG did not pass any arguments to earned, which would cause balanceOfJPEG to always revert. This bug will propagate...