Possible double free during unwinding in SmallVec::insert_many

2018-07-19T12:00:00
ID OSV:RUSTSEC-2018-0003
Type osv
Reporter Google
Modified 2021-10-19T22:14:35

Description

If an iterator passed to SmallVec::insert_many panicked in Iterator::next, destructors were run during unwinding while the vector was in an inconsistent state, possibly causing a double free (a destructor running on two copies of the same value).

This is fixed in smallvec 0.6.3 by ensuring that the vector's length is not updated to include moved items until they have been removed from their original positions. Items may now be leaked if Iterator::next panics, but they will not be dropped more than once.

Thank you to @Vurich for reporting this bug.