Denial of Service 1
Tendermint 0.33.2 and earlier does not limit the number of P2P connection requests. For each p2p connection, Tendermint allocates XXX bytes. Even though this memory is garbage collected once the connection is terminated (due to duplicate IP or reaching a maximum number of inbound peers), temporary memory spikes can lead to OOM (Out-Of-Memory) exceptions.
Tendermint 0.33.3 (and 0.32.10) limits the total number of P2P incoming connection requests to to p2p.max_num_inbound_peers + len(p2p.unconditional_peer_ids)
.
Notes:
Denial of Service 2
Tendermint 0.33.2 and earlier does not reclaim activeID
of a peer after it’s removed in Mempool
reactor. This does not happen all the time. It only happens when a connection fails (for any reason) before the Peer
is created and added to all reactors. RemovePeer
is therefore called before AddPeer
, which leads to always growing memory (activeIDs
map). The activeIDs
map has a maximum size of 65535 and the node will panic if this map reaches the maximum. An attacker can create a lot of connection attempts (exploiting Denial of Service 1), which ultimately will lead to the node panicking.
Tendermint 0.33.3 (and 0.32.10) claims activeID
for a peer in InitPeer
, which is executed before MConnection
is started.
Notes:
InitPeer
function was added to all reactors to combat a similar issue - https://github.com/tendermint/tendermint/issues/3338;github.com/tendermint/tendermint/p2p
No workarounds.
If you have any questions or comments about this advisory:
More information can be found here.
github.com/tendermint/tendermint
github.com/tendermint/tendermint/blob/master/CHANGELOG.md#denial-of-service-1
github.com/tendermint/tendermint/commit/e2d6859afd7dba4cf97c7f7d412e7d8fc908d1cd
github.com/tendermint/tendermint/issues/1696
github.com/tendermint/tendermint/issues/3338
github.com/tendermint/tendermint/security/advisories/GHSA-v24h-pjjv-mcp6
hackerone.com/reports/820317
nvd.nist.gov/vuln/detail/CVE-2020-5303