Lucene search

K
osvGoogleOSV:GHSA-QP29-WCC2-VMPC
HistoryMay 23, 2024 - 6:14 p.m.

Silverstripe HtmlEditor embed url sanitisation

2024-05-2318:14:45
Google
osv.dev
1
silverstripe
htmleditorfield
sanitisation
url
security
oembed

7 High

AI Score

Confidence

High

“Add from URL” doesn’t clearly sanitise URL server side

HtmlEditorField_Toolbar has an action HtmlEditorField_Toolbar#viewfile, which gets called by the CMS when adding a media “from a URL” (i.e. via oembed).

This action gets the URL to add in the GET parameter FileURL. However it doesn’t do any URL sanitising server side. The current logic will pass this through to Oembed, which will probably reject most dangerous URLs, but it’s possible future changes would break this.

7 High

AI Score

Confidence

High