XWiki Platform vulnerable to Code injection through NotificationRSSService

Impact

Any user who can edit their own user profile and notification settings can execute arbitrary script macros including Groovy and Python macros that allow remote code execution including unrestricted read and write access to all wiki contents. This can be reproduced with the following steps:

1. Login as a user without script or programming right.
2. Go to the notifications preferences in your user profile.
3. Disable the “Own Events Filter” and enable notifications in the notification menu for “Like”.
4. Set your first name to {{cache id="security" timeToLive="1"}}{{groovy}}println("Hello from groovy!"){{/groovy}}{{/cache}}
5. Click on the like button at the bottom left of the user profile.
6. Click on the notifications bell in the top bar and then on “RSS Feed”.

If the text “Profile of Hello from groovy!” and/or “liked by Hello from groovy!” is displayed, the attack succeeded. The expected result would have been that the entered first name is displayed as-is in the description of the feed.

Patches

This has been patched in XWiki 14.10.6 and 15.2RC1.

Workarounds

The main security fix can be manually applied by patching the affected document XWiki.Notifications.Code.NotificationRSSService as shown in the patch. This will break the link to the differences, though as this requires additional changes to Velocity templates as shown in the patch. While the default template is available in the instance and can be easily patched, the template for mentions is contained in a .jar-file and thus cannot be fixed without replacing that jar.

References

• https://jira.xwiki.org/browse/XWIKI-20610
• https://github.com/xwiki/xwiki-platform/commit/217e5bb7a657f2991b154a16ef4d5ae9c29ad39c