Synology Router Manager (SRM) 1.2.x < 1.2.5-8227-10, 1.3.x < 1.3.1-9346-7 Security Bypass Vulnerability (Synology-SA-23:10) - Unreliable Remote Version Check

# SPDX-FileCopyrightText: 2023 Greenbone AG
# Some text descriptions might be excerpted from (a) referenced
# source(s), and are Copyright (C) by the respective right holder(s).
#
# SPDX-License-Identifier: GPL-2.0-only

CPE = "cpe:/a:synology:router_manager";

if(description)
{
  script_oid("1.3.6.1.4.1.25623.1.0.170587");
  script_version("2024-03-15T15:36:48+0000");
  script_tag(name:"last_modification", value:"2024-03-15 15:36:48 +0000 (Fri, 15 Mar 2024)");
  # nb: This was initially a single VT but had to be split into two VTs in 2023. The original date
  # for both (the new and the old one) has been kept in this case.
  script_tag(name:"creation_date", value:"2023-09-29 09:27:45 +0000 (Fri, 29 Sep 2023)");
  script_tag(name:"cvss_base", value:"6.4");
  script_tag(name:"cvss_base_vector", value:"AV:N/AC:L/Au:N/C:P/I:P/A:N");

  script_tag(name:"qod_type", value:"remote_banner_unreliable");

  script_tag(name:"solution_type", value:"VendorFix");

  script_name("Synology Router Manager (SRM) 1.2.x < 1.2.5-8227-10, 1.3.x < 1.3.1-9346-7 Security Bypass Vulnerability (Synology-SA-23:10) - Unreliable Remote Version Check");

  script_category(ACT_GATHER_INFO);

  script_copyright("Copyright (C) 2023 Greenbone AG");
  script_family("General");
  script_dependencies("gb_synology_srm_consolidation.nasl");
  script_mandatory_keys("synology/srm/detected");

  script_tag(name:"summary", value:"Synology Router Manager (SRM) is prone to a security bypass
  vulnerability.");

  script_tag(name:"vuldetect", value:"Checks if a vulnerable version is present on the target host.");

  script_tag(name:"affected", value:"SRM version 1.2.x prior to 1.2.5-8227-10 and
  1.3.x prior to 1.3.1-9346-7.");

  script_tag(name:"solution", value:"Update to firmware version 1.2.5-8227-10, 1.3.1-9346-7 or
  later.");

  script_xref(name:"URL", value:"https://www.synology.com/en-global/security/advisory/Synology_SA_23_13");

  exit(0);
}

include("host_details.inc");
include("revisions-lib.inc");
include("version_func.inc");

if (!version = get_app_version(cpe: CPE, nofork: TRUE))
  exit(0);

# nb: This is checked by VT 1.3.6.1.4.1.25623.1.0.114441
if ((version =~ "^1\.2" && (revcomp(a: version, b: "1.2.5-8227") < 0)) ||
    (version =~ "^1\.3" && (revcomp(a: version, b: "1.3.1-9346") < 0)))
  exit(0);

# nb: The patch level version cannot be obtained so when the fix is on a patch level version (e.g.
# 1.1.5-6542-4 and not 1.1.5-6542), there will be 2 VTs with different qod_type.
if (version =~ "^1\.2" && (revcomp(a: version, b: "1.2.5-8227-10") < 0)) {
  report = report_fixed_ver(installed_version: version, fixed_version: "1.2.5-8227-10");
  security_message(port: 0, data: report);
  exit(0);
}

if (version =~ "^1\.3" && (revcomp(a: version, b: "1.3.1-9346-7") < 0)) {
  report = report_fixed_ver(installed_version: version, fixed_version: "1.3.1-9346-7");
  security_message(port: 0, data: report);
  exit(0);
}

exit(99);