Description

Whilst experimenting with radare2, built from version 5.6.6, we are able to induce a vulnerability at bin_dyldcache.c:125 in function va2pa , using radare2 as a harness.

 118:  static ut64 va2pa(uint64_t addr, ut32 n_maps, cache_map_t *maps, RBuffer *cache_buf, ut64 slide, ut32 *offset, ut32 *left) {
 119:  	ut64 res = UT64_MAX;
 120:  	ut32 i;
 121:  
 122:  	addr -= slide;
 123:  
 124:  	for (i = 0; i < n_maps; i++) {
 //heap buffer overflow here
 125:  		if (addr >= maps[i].address && addr < maps[i].address + maps[i].size) {
 126:  			res = maps[i].fileOffset + addr - maps[i].address;
 127:  			if (offset) {
 128:  				*offset = addr - maps[i].address;
 129:  			}
 130:  			if (left) {
 131:  				*left = maps[i].size - (addr - maps[i].address);
 132:  			}
 133:  			break;
 134:  		}
 135:  	}

Because there is no proper bounds checking, a heap-based out-of-bound read will be triggered when the software encounters a malformed file, which could result in denial of service.

We also found that the vulnerability exists in the master branch as well.

Environment

Ubuntu 20.04 LTS x86_64

gcc 10.3.0

clang 12.0.1

Proof of Concept

The POC is: poc

The reproducing process is:

# build with address sanitizer
SANITIZE=address ./sys/sanitize.sh
# disable some features of address sanitizer to avoid false positives
export ASAN_OPTIONS=detect_leaks=0:abort_on_error=1:symbolize=1:allocator_may_return_null=1:detect_odr_violation=0
# trigger the crash
./radare2 -AA -qq POC_FILE

The ASAN report is:

=================================================================
==123279==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7fffed4d7000 at pc 0x7ffff3d8b428 bp 0x7fffffffd7a0 sp 0x7fffffffd790
READ of size 8 at 0x7fffed4d7000 thread T0
    #0 0x7ffff3d8b427 in va2pa /work/libraries/radare2-latest/libr/..//libr/bin/p/bin_dyldcache.c:125
    #1 0x7ffff3d946a6 in create_cache_bins /work/libraries/radare2-latest/libr/..//libr/bin/p/bin_dyldcache.c:1250
    #2 0x7ffff3d99489 in load_buffer /work/libraries/radare2-latest/libr/..//libr/bin/p/bin_dyldcache.c:1899
    #3 0x7ffff3d2b371 in r_bin_object_new /work/libraries/radare2-latest/libr/bin/bobj.c:147
    #4 0x7ffff3d25d77 in r_bin_file_new_from_buffer /work/libraries/radare2-latest/libr/bin/bfile.c:585
    #5 0x7ffff3d037bb in r_bin_open_buf /work/libraries/radare2-latest/libr/bin/bin.c:279
    #6 0x7ffff3d03e42 in r_bin_open_io /work/libraries/radare2-latest/libr/bin/bin.c:339
    #7 0x7ffff463c094 in r_core_file_do_load_for_io_plugin /work/libraries/radare2-latest/libr/core/cfile.c:435
    #8 0x7ffff463d9b7 in r_core_bin_load /work/libraries/radare2-latest/libr/core/cfile.c:636
    #9 0x7ffff717b333 in r_main_radare2 /work/libraries/radare2-latest/libr/main/radare2.c:1184
    #10 0x5555555556ff in main /work/libraries/radare2-latest/binr/radare2/radare2.c:96
    #11 0x7ffff6f630b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    #12 0x55555555528d in _start (/work/libraries/radare2-latest/binr/radare2/radare2+0x128d)

0x7fffed4d7000 is located 0 bytes to the right of 12503040-byte region [0x7fffec8ea800,0x7fffed4d7000)
allocated by thread T0 here:
    #0 0x7ffff7693e17 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
    #1 0x7ffff3d97b0e in populate_cache_maps /work/libraries/radare2-latest/libr/..//libr/bin/p/bin_dyldcache.c:1704
    #2 0x7ffff3d99334 in load_buffer /work/libraries/radare2-latest/libr/..//libr/bin/p/bin_dyldcache.c:1893
    #3 0x7ffff3d2b371 in r_bin_object_new /work/libraries/radare2-latest/libr/bin/bobj.c:147
    #4 0x7ffff3d25d77 in r_bin_file_new_from_buffer /work/libraries/radare2-latest/libr/bin/bfile.c:585
    #5 0x7ffff3d037bb in r_bin_open_buf /work/libraries/radare2-latest/libr/bin/bin.c:279
    #6 0x7ffff3d03e42 in r_bin_open_io /work/libraries/radare2-latest/libr/bin/bin.c:339
    #7 0x7ffff463c094 in r_core_file_do_load_for_io_plugin /work/libraries/radare2-latest/libr/core/cfile.c:435
    #8 0x7ffff463d9b7 in r_core_bin_load /work/libraries/radare2-latest/libr/core/cfile.c:636
    #9 0x7ffff717b333 in r_main_radare2 /work/libraries/radare2-latest/libr/main/radare2.c:1184
    #10 0x5555555556ff in main /work/libraries/radare2-latest/binr/radare2/radare2.c:96
    #11 0x7ffff6f630b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

SUMMARY: AddressSanitizer: heap-buffer-overflow /work/libraries/radare2-latest/libr/..//libr/bin/p/bin_dyldcache.c:125 in va2pa
Shadow bytes around the buggy address:
  0x10007da92db0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10007da92dc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10007da92dd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10007da92de0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10007da92df0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x10007da92e00:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x10007da92e10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x10007da92e20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x10007da92e30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x10007da92e40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x10007da92e50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==123279==ABORTING
Aborted