Lucene search

K
githubGitHub Advisory DatabaseGHSA-HXGM-GHMV-XJJM
HistoryJul 08, 2024 - 6:37 p.m.

Directus incorrectly handles `_in` filter

2024-07-0818:37:54
CWE-284
GitHub Advisory Database
github.com
6
directus
security
broken access control
filter operators
permissions

CVSS3

6.3

Attack Vector

NETWORK

Attack Complexity

HIGH

Privileges Required

LOW

User Interaction

NONE

Scope

CHANGED

Confidentiality Impact

HIGH

Integrity Impact

NONE

Availability Impact

NONE

CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:C/C:H/I:N/A:N

AI Score

6.8

Confidence

High

EPSS

0

Percentile

9.2%

Summary

Directus >=9.23.0, <=v10.5.3 improperly handles _in, _nin operators.
It evaluates empty arrays as valid so expressions like {“role”: {“_in”: $CURRENT_USER.some_field}} would evaluate to true allowing the request to pass.

Details

This results in Broken Access Control because the rule fails to do what it was intended to do: Pass rule if field matches any of thevalues. ref: https://docs.directus.io/reference/filter-rules.html#filter-operators
In my example this would translate to “Pass rule if <collection>.role matches any of**[]**”. Which should fail. This instead passes in Directus <= v10.5.3, >=v9.23.0

PoC

{“role”: {“_in”: $CURRENT_USER.some_field}} field validation would pass if $CURRENT_USER.some_field is null.

Real scenario: Using https://github.com/u12206050/directus-extension-role-chooser with the specified versions of Directus (I tested on 10.0.0) allows users with access to this feature set their role to whatever role if they don’t have any roles assigned (user_roles.role is left with the default value, null) despite the validation rule being

validation:
    role:
      _in: $CURRENT_USER.user_roles.role

Latest version of Directus (v10.8.3 and above) handles the above validation rule correctly.

Impact

Permissions fail to open for setups relying on this filter and can lead to users getting access to things they’re not supposed to.

Affected configurations

Vulners
Node
directusdirectusRange9.23.010.5.3
VendorProductVersionCPE
directusdirectus*cpe:2.3:a:directus:directus:*:*:*:*:*:*:*:*

CVSS3

6.3

Attack Vector

NETWORK

Attack Complexity

HIGH

Privileges Required

LOW

User Interaction

NONE

Scope

CHANGED

Confidentiality Impact

HIGH

Integrity Impact

NONE

Availability Impact

NONE

CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:C/C:H/I:N/A:N

AI Score

6.8

Confidence

High

EPSS

0

Percentile

9.2%

Related for GHSA-HXGM-GHMV-XJJM