Lucene search

K
githubGitHub Advisory DatabaseGHSA-7VW7-QX38-37VR
HistoryMay 20, 2024 - 5:34 p.m.

Propel2 SQL injection possible with limit() on MySQL

2024-05-2017:34:33
CWE-89
GitHub Advisory Database
github.com
3
sql injection
propel2
mysql

8.5 High

AI Score

Confidence

Low

The limit() query method is susceptible to catastrophic SQL injection with MySQL.

For example, given a model User for a table users:

UserQuery::create()->limit('1;DROP TABLE users')->find();

This will drop the users table!

The cause appears to be a lack of integer casting of the limit input in either Propel\Runtime\ActiveQuery\Criteria::setLimit() or in Propel\Runtime\Adapter\Pdo\MysqlAdapter::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers.

This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection.

This affects all versions of Propel: 1.x, 2.x, and 3.

Affected configurations

Vulners
Node
propelpropelRange2.0.0-alpha7
CPENameOperatorVersion
propel/propelle2.0.0-alpha7

8.5 High

AI Score

Confidence

Low