CVE-2024-46791 can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open

2024-09-1807:12:46

Linux

www.cve.org

linux kernel

vulnerability

fixed

can

mcp251x

EPSS

Percentile

11.0%

JSON

In the Linux kernel, the following vulnerability has been resolved:

can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open

The mcp251x_hw_wake() function is called with the mpc_lock mutex held and
disables the interrupt handler so that no interrupts can be processed while
waking the device. If an interrupt has already occurred then waiting for
the interrupt handler to complete will deadlock because it will be trying
to acquire the same mutex.

CPU0 CPU1

mcp251x_open()
mutex_lock(&priv->mcp_lock)
request_threaded_irq()
<interrupt>
mcp251x_can_ist()
mutex_lock(&priv->mcp_lock)
mcp251x_hw_wake()
disable_irq() <– deadlock

Use disable_irq_nosync() instead because the interrupt handler does
everything while holding the mutex so it doesn’t matter if it’s still
running.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "drivers/net/can/spi/mcp251x.c"
    ],
    "versions": [
      {
        "version": "8ce8c0abcba3",
        "lessThan": "3a49b6b1caf5",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "8ce8c0abcba3",
        "lessThan": "513c8fc189b5",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "8ce8c0abcba3",
        "lessThan": "f7ab9e14b23a",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "8ce8c0abcba3",
        "lessThan": "8fecde9c3f9a",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "8ce8c0abcba3",
        "lessThan": "e554113a1cd2",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "8ce8c0abcba3",
        "lessThan": "7dd9c26bd6cf",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "affected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "drivers/net/can/spi/mcp251x.c"
    ],
    "versions": [
      {
        "version": "5.5",
        "status": "affected"
      },
      {
        "version": "0",
        "lessThan": "5.5",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.10.226",
        "lessThanOrEqual": "5.10.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.15.167",
        "lessThanOrEqual": "5.15.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.1.110",
        "lessThanOrEqual": "6.1.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.6.51",
        "lessThanOrEqual": "6.6.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.10.10",
        "lessThanOrEqual": "6.10.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.11",
        "lessThanOrEqual": "*",
        "status": "unaffected",
        "versionType": "original_commit_for_fix"
      }
    ]
  }
]