CVE-2024-45016 netem: fix return value if duplicate enqueue fails

2024-09-1115:13:52

Linux

www.cve.org

netem

linux kernel

vulnerability

fix

use-after-free

qdisc

packet duplication

EPSS

Percentile

5.1%

JSON

In the Linux kernel, the following vulnerability has been resolved:

netem: fix return value if duplicate enqueue fails

There is a bug in netem_enqueue() introduced by
commit 5845f706388a (“net: netem: fix skb length BUG_ON in __skb_to_sgvec”)
that can lead to a use-after-free.

This commit made netem_enqueue() always return NET_XMIT_SUCCESS
when a packet is duplicated, which can cause the parent qdisc’s q.qlen
to be mistakenly incremented. When this happens qlen_notify() may be
skipped on the parent during destruction, leaving a dangling pointer
for some classful qdiscs like DRR.

There are two ways for the bug happen:

If the duplicated packet is dropped by rootq->enqueue() and then
the original packet is also dropped.
If rootq->enqueue() sends the duplicated packet to a different qdisc
and the original packet is dropped.

In both cases NET_XMIT_SUCCESS is returned even though no packets
are enqueued at the netem qdisc.

The fix is to defer the enqueue of the duplicate packet until after
the original packet has been guaranteed to return NET_XMIT_SUCCESS.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "net/sched/sch_netem.c"
    ],
    "versions": [
      {
        "version": "5845f706388a",
        "lessThan": "759e3e8c4a6a",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "5845f706388a",
        "lessThan": "c414000da1c2",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "5845f706388a",
        "lessThan": "52d99a69f3d5",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "5845f706388a",
        "lessThan": "0486d31dd819",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "5845f706388a",
        "lessThan": "577d6c061946",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "5845f706388a",
        "lessThan": "e5bb2988a310",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "5845f706388a",
        "lessThan": "c07ff8592d57",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "affected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "net/sched/sch_netem.c"
    ],
    "versions": [
      {
        "version": "5.0",
        "status": "affected"
      },
      {
        "version": "0",
        "lessThan": "5.0",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.4.283",
        "lessThanOrEqual": "5.4.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.10.225",
        "lessThanOrEqual": "5.10.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.15.166",
        "lessThanOrEqual": "5.15.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.1.107",
        "lessThanOrEqual": "6.1.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.6.48",
        "lessThanOrEqual": "6.6.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.10.7",
        "lessThanOrEqual": "6.10.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.11",
        "lessThanOrEqual": "*",
        "status": "unaffected",
        "versionType": "original_commit_for_fix"
      }
    ]
  }
]