CVE-2024-27391 wifi: wilc1000: do not realloc workqueue everytime an interface is added

2024-05-0113:05:16

Linux

www.cve.org

linux kernel

wifi

wilc1000

vulnerability

workqueue

interface

driver

phy

leakage

fix

cve

6.6 Medium

AI Score

Confidence

Low

0.0004 Low

EPSS

Percentile

15.7%

JSON

In the Linux kernel, the following vulnerability has been resolved:

wifi: wilc1000: do not realloc workqueue everytime an interface is added

Commit 09ed8bfc5215 (“wilc1000: Rename workqueue from “WILC_wq” to
“NETDEV-wq””) moved workqueue creation in wilc_netdev_ifc_init in order to
set the interface name in the workqueue name. However, while the driver
needs only one workqueue, the wilc_netdev_ifc_init is called each time we
add an interface over a phy, which in turns overwrite the workqueue with a
new one. This can be observed with the following commands:

for i in $(seq 0 10)
do
iw phy phy0 interface add wlan1 type managed
iw dev wlan1 del
done
ps -eo pid,comm|grep wlan

39 kworker/R-wlan0
98 kworker/R-wlan1
102 kworker/R-wlan1
105 kworker/R-wlan1
108 kworker/R-wlan1
111 kworker/R-wlan1
114 kworker/R-wlan1
117 kworker/R-wlan1
120 kworker/R-wlan1
123 kworker/R-wlan1
126 kworker/R-wlan1
129 kworker/R-wlan1

Fix this leakage by putting back hif_workqueue allocation in
wilc_cfg80211_init. Regarding the workqueue name, it is indeed relevant to
set it lowercase, however it is not attached to a specific netdev, so
enforcing netdev name in the name is not so relevant. Still, enrich the
name with the wiphy name to make it clear which phy is using the workqueue.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "drivers/net/wireless/microchip/wilc1000/cfg80211.c",
      "drivers/net/wireless/microchip/wilc1000/netdev.c"
    ],
    "versions": [
      {
        "version": "09ed8bfc5215",
        "lessThan": "515cc676dfbc",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "09ed8bfc5215",
        "lessThan": "4041c60a9d54",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "09ed8bfc5215",
        "lessThan": "90ae293d1d25",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "09ed8bfc5215",
        "lessThan": "9ab0c303ccab",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "09ed8bfc5215",
        "lessThan": "328efda22af8",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "affected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "drivers/net/wireless/microchip/wilc1000/cfg80211.c",
      "drivers/net/wireless/microchip/wilc1000/netdev.c"
    ],
    "versions": [
      {
        "version": "5.17",
        "status": "affected"
      },
      {
        "version": "0",
        "lessThan": "5.17",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.1.83",
        "lessThanOrEqual": "6.1.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.6.23",
        "lessThanOrEqual": "6.6.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.7.11",
        "lessThanOrEqual": "6.7.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.8.2",
        "lessThanOrEqual": "6.8.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.9",
        "lessThanOrEqual": "*",
        "status": "unaffected",
        "versionType": "original_commit_for_fix"
      }
    ]
  }
]