CVE-2023-52874 x86/tdx: Zero out the missing RSI in TDX_HYPERCALL macro

2024-05-2115:32:07

Linux

www.cve.org

linux kernel

vulnerability

tdx_hypercall

speculative execution

registers

commit fix

6.4 Medium

AI Score

Confidence

High

0.0004 Low

EPSS

Percentile

15.5%

JSON

In the Linux kernel, the following vulnerability has been resolved:

x86/tdx: Zero out the missing RSI in TDX_HYPERCALL macro

In the TDX_HYPERCALL asm, after the TDCALL instruction returns from the
untrusted VMM, the registers that the TDX guest shares to the VMM need
to be cleared to avoid speculative execution of VMM-provided values.

RSI is specified in the bitmap of those registers, but it is missing
when zeroing out those registers in the current TDX_HYPERCALL.

It was there when it was originally added in commit 752d13305c78
(“x86/tdx: Expand __tdx_hypercall() to handle more arguments”), but was
later removed in commit 1e70c680375a (“x86/tdx: Do not corrupt
frame-pointer in __tdx_hypercall()”), which was correct because %rsi is
later restored in the “pop %rsi”. However a later commit 7a3a401874be
(“x86/tdx: Drop flags from __tdx_hypercall()”) removed that “pop %rsi”
but forgot to add the “xor %rsi, %rsi” back.

Fix by adding it back.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "arch/x86/coco/tdx/tdcall.S"
    ],
    "versions": [
      {
        "version": "7a3a401874be",
        "lessThan": "2191950d35d8",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "7a3a401874be",
        "lessThan": "de4c5bacca4f",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "7a3a401874be",
        "lessThan": "5d092b66119d",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "affected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "arch/x86/coco/tdx/tdcall.S"
    ],
    "versions": [
      {
        "version": "6.4",
        "status": "affected"
      },
      {
        "version": "0",
        "lessThan": "6.4",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.5.12",
        "lessThanOrEqual": "6.5.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.6.2",
        "lessThanOrEqual": "6.6.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.7",
        "lessThanOrEqual": "*",
        "status": "unaffected",
        "versionType": "original_commit_for_fix"
      }
    ]
  }
]