CVE-2022-48733 btrfs: fix use-after-free after failure to create a snapshot

2024-06-2011:13:20

Linux

www.cve.org

vulnerability

btrfs

use-after-free

linux kernel

snapshot fix

transaction abort

0.0004 Low

EPSS

Percentile

15.7%

JSON

In the Linux kernel, the following vulnerability has been resolved:

btrfs: fix use-after-free after failure to create a snapshot

At ioctl.c:create_snapshot(), we allocate a pending snapshot structure and
then attach it to the transaction’s list of pending snapshots. After that
we call btrfs_commit_transaction(), and if that returns an error we jump
to ‘fail’ label, where we kfree() the pending snapshot structure. This can
result in a later use-after-free of the pending snapshot:

We allocated the pending snapshot and added it to the transaction’s
list of pending snapshots;
We call btrfs_commit_transaction(), and it fails either at the first
call to btrfs_run_delayed_refs() or btrfs_start_dirty_block_groups().
In both cases, we don’t abort the transaction and we release our
transaction handle. We jump to the ‘fail’ label and free the pending
snapshot structure. We return with the pending snapshot still in the
transaction’s list;
Another task commits the transaction. This time there’s no error at
all, and then during the transaction commit it accesses a pointer
to the pending snapshot structure that the snapshot creation task
has already freed, resulting in a user-after-free.

This issue could actually be detected by smatch, which produced the
following warning:

fs/btrfs/ioctl.c:843 create_snapshot() warn: ‘&pending_snapshot->list’ not removed from list

So fix this by not having the snapshot creation ioctl directly add the
pending snapshot to the transaction’s list. Instead add the pending
snapshot to the transaction handle, and then at btrfs_commit_transaction()
we add the snapshot to the list only when we can guarantee that any error
returned after that point will result in a transaction abort, in which
case the ioctl code can safely free the pending snapshot and no one can
access it anymore.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "fs/btrfs/ioctl.c",
      "fs/btrfs/transaction.c",
      "fs/btrfs/transaction.h"
    ],
    "versions": [
      {
        "version": "1da177e4c3f4",
        "lessThan": "a7b717fa1516",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "1da177e4c3f4",
        "lessThan": "9372fa1d73da",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "1da177e4c3f4",
        "lessThan": "28b21c558a37",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "affected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "fs/btrfs/ioctl.c",
      "fs/btrfs/transaction.c",
      "fs/btrfs/transaction.h"
    ],
    "versions": [
      {
        "version": "5.15.22",
        "lessThanOrEqual": "5.15.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.16.8",
        "lessThanOrEqual": "5.16.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.17",
        "lessThanOrEqual": "*",
        "status": "unaffected",
        "versionType": "original_commit_for_fix"
      }
    ]
  }
]