Lucene search

K
code423n4Code4renaCODE423N4:2022-08-FIATDAO-FINDINGS-ISSUES-184
HistoryAug 15, 2022 - 12:00 a.m.

Blocklist contract lack an unblock mechanism

2022-08-1500:00:00
Code4rena
github.com
5

Lines of code

Vulnerability details

Impact

In Blocklist contract, the manager can block a contract from accessing VotingEscrow by calling the block function.
If the manager calls the block function on a contract due to some misunderstanding, the manager cannot resume the contract’s access to VotingEscrow after the misunderstanding is resolved.

    function block(address addr) external {
        require(msg.sender == manager, "Only manager");
        require(_isContract(addr), "Only contracts");
        _blocklist[addr] = true;
        IVotingEscrow(ve).forceUndelegate(addr);
    }

#Proof of Concept

Tools Used

None

Recommended Mitigation Steps

Consider adding the unblock function to allow the manager to unblock a contract


The text was updated successfully, but these errors were encountered:

All reactions