Upgraded Q -> H from 25 [1655007954017]

Judge has assessed an item in Issue #25 as High risk. The relevant finding follows:

Fees should have a boundary of 100% (10000): <https://github.com/code-423n4/2022-03-joyn/blob/main/royalty-vault/contracts/RoyaltyVault.sol#L68&gt;

Otherwise the contract will try to transfer more than possible which will result in reverts: <https://github.com/code-423n4/2022-03-joyn/blob/main/royalty-vault/contracts/RoyaltyVault.sol#L40&gt;

It might also be helpful the have an fixed upper boundary that doesn’t allow the platform to collect more than a set amount of fees, e.g. 10%.

The text was updated successfully, but these errors were encountered:

All reactions