Wrong implementation of OperatorResolver::areOperatorsImported

This issue has been created to upgrade a QA report submission to a medium severity finding. From kenzo:

Wrong implementation of OperatorResolver::areOperatorsImported
The function as implemented will return true if the operators have same implementation but different selector,
or different implementation but same selector.
This might cause users/admins to think an upgrade has happened successfully when it fact it was not.
Code ref:

        if (
            operators[names[i]].implementation != destinations[i].implementation &&
            operators[names[i]].selector != destinations[i].selector
        ) {
            return false;
        }

The condition should be ||, not &&.

The text was updated successfully, but these errors were encountered:

All reactions