areOperatorsImported has incorrect logic

This issue has been created to upgrade a QA report submission to a medium severity finding. From 0xliumin:

areOperatorsImported has incorrect logic

Right now, this function returns false if the implementation AND the selector don’t match. It’s possible to provide a destination with either a different implementation or selector, and still get a true response.

<https://github.com/code-423n4/2022-02-nested/blob/69cf51d8e4eeb8bce3025db7f4f74cc565c9fad3/contracts/OperatorResolver.sol#L42&gt;
Mitigation is to change && to ||.

The text was updated successfully, but these errors were encountered:

All reactions