Lucene search

K
code423n4Code4renaCODE423N4:2022-02-CONCUR-FINDINGS-ISSUES-269
HistoryApr 28, 2022 - 12:00 a.m.

Potential reentrance in claimRewards

2022-04-2800:00:00
Code4rena
github.com
4

Judge @GalloDaSballo has assessed the 1st item in QA Report #36 as Medium risk. The relevant finding follows:

#POC

            IERC20(_tokens[i]).safeTransfer(msg.sender, getting);
            reward[msg.sender][_tokens[i]] = 0;

Considering there are exterTokens, it is possible that some token will provide reentry opportunities.

Mitigation

change to order of L37 and L38

            reward[msg.sender][_tokens[i]] = 0;
            IERC20(_tokens[i]).safeTransfer(msg.sender, getting);

The text was updated successfully, but these errors were encountered:

All reactions