Lucene search

K
atlassian1c017edd2c81JSWSERVER-21915
HistoryAug 11, 2023 - 10:30 a.m.

Smart commits are processed in Jira for repositories without smart commits when synced via git webhooks

2023-08-1110:30:24
1c017edd2c81
jira.atlassian.com
8
jira
bug
integration
webhooks
synchronization
security
repository

h3. Issue Summary

This is reproducible on Data Center: yes

Explanation:
This bug shows up only for integration using webhooks. Smar commits works correctly when data is being synced during hourly polling job.

Environment requirements:
Jira needs to be available for Git instance to let git webhooks work.
h3. Steps to Reproduce

In Gitlab/Github/BBcloud instance create organisation ORG containing repository REPO1

Link Git ORG with Jira via DVCS plugin (with default checkbox set)

In DVCSΒ ORG account turn, uncheck β€œSmart Commits” for REPO2

Create Jira project with specific key. Let’s say β€œPROJ”, and create one issue (will beΒ {}PROJ-1{}),

Create corresponding branch+commit to with same ({}PROJ-1){} key and smart commit command. In example set commit message as β€œ{}PROJ-1 #comment some comment to be set in Jira issue{}”.

Check Jira issueΒ PROJ-1

h3. Expected Results

Only development panel data is updated (1 branch, 1 commit).
No comment added to the issue, because we have turned off smart commits for this repository.
h3. Actual Results

Development panel data is updated (1 branch, 1 commit), and comment is added to the issue - same ignoring smart commits settings in DVCS
h3. Workaround
Adding the [Dark Feature|https://confluence.atlassian.com/jirakb/enable-dark-feature-in-jira-959286331.html] below is the only way to work around this issue.
Keep in mind that this reverts the webhook processing to the old (pre-8.13) behavior and can imply in synchronization delays and issues, especially in larger organizations
{noformat}
dvcs.connector.polling.synchronization.enabled
{noformat}

As a reference, this dark feature reverts the improvements detailed in [Improving the DVCS sync performance by migrating old webhooks to the new format|https://confluence.atlassian.com/jirakb/improving-the-dvcs-sync-performance-by-migrating-old-webhooks-to-the-new-format-1155487070.html]

Affected configurations

Vulners
Node
atlassianjira_software_data_centerRange≀8.14.0
OR
atlassianjira_software_data_centerRange≀8.20.0
OR
atlassianjira_software_data_centerRange≀9.4.0
OR
atlassianjira_software_data_centerRange<9.12.0
OR
atlassianjira_software_data_centerRange<9.13.0